-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(treasury): split the burn tax to the distribution module #272
Conversation
Cosmos AllocateTokens from FeeCollector: https://github.com/cosmos/cosmos-sdk/blob/v0.45.13/x/distribution/keeper/allocation.go#L16. Seems should split the Burn tax to the FeeCollector? @fragwuerdig @nghuyenthevinh2000 @inon-man |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should refactor codes here. It's confusing after removing FundCommunityPool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please hold merging it because it's a consensus breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a changelog entry. Add it under [Unreleased] section.
@inon-man No, it's my test result, and that is the expected result. |
@nghuyenthevinh2000 @fragwuerdig Can you guys review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked over, LGTM!
Summary of changes
Proposal link: https://station.terrarebels.net/proposal/11513
Closes: #232
Report of required housekeeping
(FOR ADMIN) Before merging