Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous performance improvements #375

Closed
classilla opened this issue Apr 11, 2017 · 22 comments
Closed

Miscellaneous performance improvements #375

classilla opened this issue Apr 11, 2017 · 22 comments

Comments

@classilla
Copy link
Owner

classilla commented Apr 11, 2017

@classilla
Copy link
Owner Author

Easy win for spellcheck (we use case nsISelectionController::SELECTION_SPELLCHECK but it's the same code in the same location, approximately).
https://hg.mozilla.org/mozilla-central/rev/abfece312d74

@classilla
Copy link
Owner Author

Kind of a duh change.
https://hg.mozilla.org/mozilla-central/rev/1fb8edcd2a7c

@classilla
Copy link
Owner Author

This is a consideration after the string changes above land, but there might be some risk in it given that it changes caching performance.
https://bugzilla.mozilla.org/show_bug.cgi?id=1353758

@classilla
Copy link
Owner Author

We do have the block-scoped ReentrantMonitor XPCOM object, so this should be nice to have also.
https://bugzilla.mozilla.org/show_bug.cgi?id=1354389

@classilla
Copy link
Owner Author

This one is really easy.
https://hg.mozilla.org/mozilla-central/rev/609c12db5796

@classilla
Copy link
Owner Author

@classilla
Copy link
Owner Author

This needs a couple backbugs (see the event.target code), but should work (we do have event.originalTarget and ._scrollbox).

https://hg.mozilla.org/mozilla-central/rev/c0e6cf04adb9

@classilla
Copy link
Owner Author

We could consider this after the 'duh' change directly above but the comments imply this isn't really all that worth it.
https://hg.mozilla.org/mozilla-central/rev/ee9bd670aadf

@classilla
Copy link
Owner Author

Another easy change.
https://bugzilla.mozilla.org/show_bug.cgi?id=1349742

@classilla
Copy link
Owner Author

classilla commented Apr 22, 2017

There are a couple of leftover telemetry things this removes which we should also be able to do safely. (Also remove the bind(this))
https://hg.mozilla.org/mozilla-central/rev/1685702d2d6a

@classilla
Copy link
Owner Author

@classilla
Copy link
Owner Author

Another gimme. I love Photon.
https://hg.mozilla.org/mozilla-central/rev/c5bdfc3ba44d

@classilla
Copy link
Owner Author

classilla commented Apr 22, 2017

We don't need the second patch which is just a rename. The performance implications are unclear since we are not e10s by design, but it seems like it would certainly help correctness as well.
https://hg.mozilla.org/mozilla-central/rev/c5bdfc3ba44d
However, verify this does not cause https://bugzilla.mozilla.org/show_bug.cgi?id=1357841

(Note to self: subscribe to these bugs, too, so we get regression alerts)

@classilla
Copy link
Owner Author

Improve pref management for IME.
https://hg.mozilla.org/mozilla-central/rev/f0127a117bcb

@classilla
Copy link
Owner Author

Eliminate a layout flush.
https://hg.mozilla.org/mozilla-central/rev/1be01419533e

@classilla
Copy link
Owner Author

Avoid a layout flush when windows activate/deactivate. This is quite noticeable on our systems, but we should make sure it does not regress lightweight themes.
https://hg.mozilla.org/mozilla-central/rev/c8c1952346f3

classilla added a commit that referenced this issue May 3, 2017
…M1345315 M1356655 M1356663 M1357638 M1358809 M1307134
classilla added a commit that referenced this issue May 3, 2017
…742 M1345315 M1356655 M1356663 M1357638 M1358809 M1307134 M1331342 M1220466
@classilla
Copy link
Owner Author

Speculatively connecting on mousedown is logical and easy to add.
https://bugzilla.mozilla.org/show_bug.cgi?id=1348278

@classilla
Copy link
Owner Author

This patch can mostly be added as is, but needs to be to editor/libeditor/nsEditor.cpp.

https://hg.mozilla.org/integration/autoland/rev/ebdf1fcdd758

classilla added a commit that referenced this issue May 6, 2017
classilla added a commit that referenced this issue May 7, 2017
classilla added a commit that referenced this issue May 9, 2017
classilla added a commit that referenced this issue May 9, 2017
@classilla
Copy link
Owner Author

This is easy enough.
https://hg.mozilla.org/mozilla-central/rev/34b822f38567

classilla added a commit that referenced this issue May 13, 2017
classilla added a commit that referenced this issue May 13, 2017
classilla added a commit that referenced this issue May 17, 2017
classilla added a commit that referenced this issue May 25, 2017
@classilla
Copy link
Owner Author

What's left that's worth doing:

https://hg.mozilla.org/mozilla-central/rev/c8c1952346f3 (M1334642)
https://hg.mozilla.org/mozilla-central/rev/1f5902db90a7 (M1275282)
(followed by
https://hg.mozilla.org/mozilla-central/rev/4cda93365031 (M1352323)
)

This turns out to be harder:
https://hg.mozilla.org/mozilla-central/rev/c30756846670 (M1353187)
(followed by
https://hg.mozilla.org/mozilla-central/rev/63a14b2f3c74 (same)
note change in bit and bit API. This might be harder to land.
)

All others are either done or wontfix.

@classilla
Copy link
Owner Author

If M1352323 sticks, then we should also add https://hg.mozilla.org/mozilla-central/rev/0852d89a06a1 from M1038099.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant