Implemented swatches or "customizable palette" #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a maximum of 7 swatches to be displayed under the color grid, which allows customizable colors to be selected. Implements claviska#50
…me more in the base64 data uri
claviska
added a commit
that referenced
this pull request
Jan 26, 2016
Implemented swatches or "customizable palette"
|
This is a solid PR. Thanks! I've only noticed one issue so far. When swatches are enabled and opacity is set, the control sometimes renders hex values and other times RGBA values. For example, try selecting a swatch and then try selecting from the palette on the last control: http://labs.abeautifulsite.net/jquery-minicolors/index.html |
|
Added an issue to make sure we don't forget to address this before the next version bump: #187 |
|
Oh, yes you're right, tomorrow I will find time to fix this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the feature requested in #50, please take a look.