Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Region Specifications and Simplify Flagging Routine #117

Open
mandli opened this issue Oct 12, 2014 · 2 comments
Open

Consolidate Region Specifications and Simplify Flagging Routine #117

mandli opened this issue Oct 12, 2014 · 2 comments
Labels

Comments

@mandli
Copy link
Member

mandli commented Oct 12, 2014

Remove level restrictions for topograpy, dtopography, and qinit in favor of just specifying regions. A check would be made to see if a point was in any of the remaining regions and if it was not would be generally allowed to be flagged. This would imply that regions would then have to be specified in the same locations for a given topography for instance to gain the same functionality as before. This can more than likely be taken care of in the python class that implements this behavior.

@mandli mandli added the feature label Oct 12, 2014
@rjleveque
Copy link
Member

Note that $CLAW/amrclaw/src/2d/flagregions2.f90 appears to flag based on regions and so does $CLAW/geoclaw/src/2d/shallow/flag2refine.f90. @mjberger: Are both being used?

Also some geoclaw/example Makefiles include both flagregions2.f90 and flagregions.f and should be cleaned up. The latter doesn't even exist although there is still a deprecated flagregions.f90.

@mandli
Copy link
Member Author

mandli commented Oct 27, 2014

In GeoClaw then are we checking for regions twice then?

hudaquresh pushed a commit to hudaquresh/geoclaw that referenced this issue Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants