Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in call to update_gauges? #402

Merged
merged 1 commit into from Aug 16, 2019
Merged

Conversation

rjleveque
Copy link
Member

This one line seems to have two bugs in it, can you take a look @mjberger or @mandli?

The corresponding line in amrclaw/src/2d/advanc.f also seems to have one of the bugs. There it has

           call update_gauges(alloc(locnew:locnew+nvar*mitot*mjtot),
     .                       alloc(locaux:locaux+nvar*mitot*mjtot),
     .                       xlow,ylow,nvar,mitot,mjtot,naux,mptr)

and I think nvar should be naux on the second line? Also the same problem in 1d and 3d amrclaw.

I came across this when reviewing #358 since I'd like to update that and try it out, and noticed there was a commit that partly fixed this line and then it was reverted in the second commit. Not sure why but maybe @xinshengqin can comment.

@mandli
Copy link
Member

mandli commented Jul 30, 2019

It looks wrong to me as well.

@mandli mandli added this to the 5.6.1 milestone Aug 16, 2019
@mandli mandli merged commit b65d917 into clawpack:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants