Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit time stepping #33

Open
mparsani opened this issue Jun 20, 2011 · 8 comments
Open

Implicit time stepping #33

mparsani opened this issue Jun 20, 2011 · 8 comments
Assignees

Comments

@mparsani
Copy link
Contributor

Benchmark test case still need to be defined. We are looking for it. It should be defined in ONE or MAXIMUM TWO DAYS. Based on the selected test case the next steps should be defined.

@ghost ghost assigned mparsani Jun 20, 2011
@ahmadia
Copy link
Member

ahmadia commented Jun 20, 2011

Matteo, is this related to #22? Is this something you need help with or you are putting up for personal tracking?

@mparsani
Copy link
Contributor Author

Hi Aron,
no #22 is related to Jed implementation of implicit TS with PETSc. Issue #33
is different: we want to implement our own implicit TS and use petsc to
solve the nonlinear system.
...but sure your are an expert of PetClaw so your help is precious!

On 20 June 2011 21:23, ahmadia <
reply@reply.github.com>wrote:

Matteo, is this related to #22? Is this something you need help with or
you are putting up for personal tracking?

Reply to this email directly or view it on GitHub:
#33 (comment)

Matteo Parsani

@mparsani
Copy link
Contributor Author

mparsani commented Jul 1, 2011

Starting date: tomorrow, July 2, 2011

@ahmadia
Copy link
Member

ahmadia commented Jul 2, 2011

Hi Matteo,

I don't know nearly enough about the functions you are calling/modifying to
give you any advice out of hand, but if you think it's worth trying to
explain the mathematics and computations to me, I will do my best to advise
your refactoring strategy :)

Aron

On Sat, Jul 2, 2011 at 3:13 PM, mparsani <
reply@reply.github.com>wrote:

The implementation of the subroutine that construct the nonlinear function
requires:

  • implementation of a new function that "replaces/modifies" step1/2.f for
    the classic solver
    • implementation of a new function that "replaces/modifies" flux1.f90 for
      the sharpclaw solver

Those two functions will call the Riemann solver and manipulate the
fluctuations to get the nonlinear function. This will be passed back to
ClawSolver1D/2D or SharpClawSolver1D/2D (in python) which will call the
PETSc nonlinear solver.

Is this okay for all the developers? Do you have a better solution?

Reply to this email directly or view it on GitHub:
#33 (comment)

@mparsani
Copy link
Contributor Author

mparsani commented Jul 2, 2011

SharpClawSolver: uses the method of lines. Thus, we already have all the functions to construct the nonlinear function.
Classic implicit : the step function in clawpack.py must be modified when the implicit LW is used. In addition, Classic1.f can not be used.

@ahmadia
Copy link
Member

ahmadia commented Jul 2, 2011

I think it makes sense to extend SharpClaw in this case then.

A

On Sat, Jul 2, 2011 at 4:55 PM, mparsani <
reply@reply.github.com>wrote:

SharpClawSolver: uses the method of lines. Thus, we already have all the
functions to construct the nonlinear function.
Classic implicit : the step function in clawpack.py must be modified when
the implicit LW is used. In addition, Classic1.f can not be used.

Reply to this email directly or view it on GitHub:
#33 (comment)

@mparsani
Copy link
Contributor Author

mparsani commented Jul 2, 2011

Yes. I'll start with SharpClaw.

Thanks.

Matteo

On 2 July 2011 17:22, ahmadia <
reply@reply.github.com>wrote:

I think it makes sense to extend SharpClaw in this case then.

A

On Sat, Jul 2, 2011 at 4:55 PM, mparsani <
reply@reply.github.com>wrote:

SharpClawSolver: uses the method of lines. Thus, we already have all the
functions to construct the nonlinear function.
Classic implicit : the step function in clawpack.py must be modified when
the implicit LW is used. In addition, Classic1.f can not be used.

Reply to this email directly or view it on GitHub:
#33 (comment)

Reply to this email directly or view it on GitHub:
#33 (comment)

Matteo Parsani

@mparsani
Copy link
Contributor Author

mparsani commented Jul 2, 2011

Last message for today, sorry: I did not take into account that sharpclaw has not been tested thoroughly with mapped grids. Thus, since for the paper we want an Euler flow over a round cylinder, I'll start with the implicit LW.

Best Regards,
Matteo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants