Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-facing step example #451

Merged
merged 3 commits into from
Jul 24, 2014
Merged

Forward-facing step example #451

merged 3 commits into from
Jul 24, 2014

Conversation

ketch
Copy link
Member

@ketch ketch commented Jul 24, 2014

This builds on and replaces #445. Mainly, I've edited the comments to better document this example. There are some unfortunate things:

  • Using the Roe solver (and Classic) we get a carbuncle instability after a short time. I understand the solution is to use an HLL solver.
  • The approach we're using for internal boundaries seems to work well for Classic, but not for SharpClaw. I think this is because the values used for reconstruction don't make sense after a while. We could implement a different approach, in which cell values inside the step are overwritten in a before_step routine, but there is then ambiguity in what value to write to cells near the corner of the step.

@ketch ketch mentioned this pull request Jul 24, 2014
@mandli
Copy link
Member

mandli commented Jul 24, 2014

This looks like it's failing with the same problem as before when we were having trouble with our <#> version.

@ketch
Copy link
Member Author

ketch commented Jul 24, 2014

Okay, I rebased on master. Let's see if that fixes it.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.47%) when pulling 5d9da81 on ketch:forward_step into 530d7c0 on clawpack:master.

mandli added a commit that referenced this pull request Jul 24, 2014
Forward-facing step example
@mandli mandli merged commit 4c06b7a into clawpack:master Jul 24, 2014
@mandli
Copy link
Member

mandli commented Jul 24, 2014

Passing now, merging now.

@ketch ketch deleted the forward_step branch July 24, 2014 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants