Pass both auxbc and qbc to user BC routines #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes specfic BC routines _apply_q_bcs and _apply_aux_bcs to provide a clean interface to boundary condtions. Currently works with non-custom boundary conditions.
Also clean up a bit of the code
Also add a warning message to tell users to change their function signatures.
|
You broke it! I like the changes you made here, makes this more readable. I think the failing test might be due to the above comments. |
|
Right. Should be fixed now. |
mandli
added a commit
that referenced
this pull request
Jul 25, 2014
Pass both auxbc and qbc to user BC routines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as an optional modification to #450. I've simply renamed some variables and tried to improve the readability and documentation of the new BC functions written by @mandli. I also eliminated a little bit of code.