Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of using the proposed new constants available from Riemann. #454

Merged
merged 3 commits into from
Sep 22, 2014

Conversation

ketch
Copy link
Member

@ketch ketch commented Jul 27, 2014

This shows an example of how the values available in clawpack/riemann#77 can be used to write more readable PyClaw problem scripts.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0%) when pulling cd10adb on ketch:constants_and_indices into 47a3c79 on clawpack:master.

@mandli
Copy link
Member

mandli commented Jul 28, 2014

I like this type of use case where the variable names just point to indices. I do something similar in some of the multi-layer and storm surge code where the indices in the aux-arrays can move around.

@ketch
Copy link
Member Author

ketch commented Sep 18, 2014

Travis is failing with

tests against expected sharpclaw results ... ERROR
tests against expected sharpclaw results ... ERROR
At line 29 of file /home/travis/build/clawpack/pyclaw/src/pyclaw/sharpclaw/ClawParams.f90
Fortran runtime error: Attempt to DEALLOCATE unallocated 'xlower'

I cannot reproduce this failure locally, and I cannot fathom what is causing it. Any ideas?

@ketch ketch mentioned this pull request Sep 18, 2014
@mandli
Copy link
Member

mandli commented Sep 18, 2014

I saw this before as well but do not remember exactly what fixed it. I tried following the code but that did not shed any light on what was going on. I think it eventually resolved itself and may have been due to incompatible versions.

@ketch
Copy link
Member Author

ketch commented Sep 18, 2014

Ah, maybe we just need to update Riemann in Clawpack, so that Travis pulls
the latest version of Riemann?

@mandli
Copy link
Member

mandli commented Sep 18, 2014

That would be my best guess, my best guess is that it might be a function signature mismatch problem.

* master:
  Add 3D shock bubble example, with IPython notebook plotting example using yt and mplot3d.
  Make sure setplot_func variable always gets defined.
  Don't store gamma1 in problem_data.

Conflicts:
	examples/euler_1d/shocksine.py
	examples/euler_1d/woodward_colella_blast.py
	examples/euler_3d/Sedov.py
	examples/euler_3d/shocktube.py
@ketch
Copy link
Member Author

ketch commented Sep 19, 2014

Okay, it seems like it couldn't be an issue with updates to Riemann, since that has been updated very recently in clawpack. I thought maybe it was related to not having merged in the elimination of gamma1, but merging that doesn't seem to have made any difference.

@mandli
Copy link
Member

mandli commented Sep 19, 2014

I can try and recreate the error.

@ketch
Copy link
Member Author

ketch commented Sep 21, 2014

Any luck?

@mandli
Copy link
Member

mandli commented Sep 22, 2014

Nope, I cannot reproduce this although I have an idea why and will try again tomorrow.

@ketch
Copy link
Member Author

ketch commented Sep 22, 2014

It looks like the Riemann update was the problem after all. Assuming the parallel build passes, let's get this in to the final 5.2.1 release.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) when pulling fd038c0 on ketch:constants_and_indices into 236ff06 on clawpack:master.

ketch added a commit that referenced this pull request Sep 22, 2014
Example of using the proposed new constants available from Riemann.
@ketch ketch merged commit d84a774 into clawpack:master Sep 22, 2014
@ketch ketch deleted the constants_and_indices branch November 5, 2014 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants