Example of using the proposed new constants available from Riemann. #454
Conversation
|
I like this type of use case where the variable names just point to indices. I do something similar in some of the multi-layer and storm surge code where the indices in the aux-arrays can move around. |
ketch
force-pushed
the
constants_and_indices
branch
from
cd10adb
to
42492b7
Compare
|
Travis is failing with I cannot reproduce this failure locally, and I cannot fathom what is causing it. Any ideas? |
|
I saw this before as well but do not remember exactly what fixed it. I tried following the code but that did not shed any light on what was going on. I think it eventually resolved itself and may have been due to incompatible versions. |
|
Ah, maybe we just need to update Riemann in Clawpack, so that Travis pulls |
|
That would be my best guess, my best guess is that it might be a function signature mismatch problem. |
* master: Add 3D shock bubble example, with IPython notebook plotting example using yt and mplot3d. Make sure setplot_func variable always gets defined. Don't store gamma1 in problem_data. Conflicts: examples/euler_1d/shocksine.py examples/euler_1d/woodward_colella_blast.py examples/euler_3d/Sedov.py examples/euler_3d/shocktube.py
|
Okay, it seems like it couldn't be an issue with updates to Riemann, since that has been updated very recently in clawpack. I thought maybe it was related to not having merged in the elimination of gamma1, but merging that doesn't seem to have made any difference. |
|
I can try and recreate the error. |
|
Any luck? |
|
Nope, I cannot reproduce this although I have an idea why and will try again tomorrow. |
|
It looks like the Riemann update was the problem after all. Assuming the parallel build passes, let's get this in to the final 5.2.1 release. |
Example of using the proposed new constants available from Riemann.
This shows an example of how the values available in clawpack/riemann#77 can be used to write more readable PyClaw problem scripts.