Rising hot sphere examples #468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to fix bug related to capacity function for transverse_waves = 21 and 22 dtdx, dtdy, and dtdz need to be divided by the capacity function when passed into flux3()
Fixed bug for transverse_waves==21 and 22 where dtdz and dtdy need to be divided by the capacity function. These are passed from step3.f90. The variable names have been changed to reflect this change.
Adding a hot sphere rising in a stabilized equilibrium atmosphere for the 3D Euler equations in Cartesian coordinates. Riemann solver added with PR: clawpack/riemann#85
…herical Coordinates Adding a hot sphere rising in a stabilized equilibrium atmosphere for the 3D Euler equations in Earth centered spherical coordinates. Riemann solver added with PR: clawpack/riemann#85
Adding a hot sphere rising in a stabilized equilibrium atmosphere for the 3D Euler equations in Cartesian coordinates. Riemann solver added with PR: clawpack/riemann#85
…herical Coordinates Adding a hot sphere rising in a stabilized equilibrium atmosphere for the 3D Euler equations in Earth centered spherical coordinates. Riemann solver added with PR: clawpack/riemann#85
|
I think there's some files changed in here that you may not have meant to. You will probably need to rebase your branch on the current master branch so that you do not inadvertently roll back PyClaw to the 5.1 version. |
|
Yeah, I screwed it up after trying to merge my branch back into the master. I'm going to try to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples for the 3D Euler equations in general geometries using f-wave approach. See clawpack/riemann#85 for Riemann solver.