Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add OutputController basic functionality #508

Merged
merged 2 commits into from
Mar 19, 2015

Conversation

mandli
Copy link
Member

@mandli mandli commented Feb 23, 2015

This PR adds a first go at a controller for output that could hide a lot of the tedium and state behind doing file IO in PyClaw.

Initially this came out of a discussion (clawpack/visclaw#144) on how to fix some weirdness in the VisClaw gettime function.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 26.58% when pulling 3da9c57 on mandli:add-output-controller into 78019c0 on clawpack:master.

@ketch
Copy link
Member

ketch commented Feb 25, 2015

This looks reasonable, but I think before merging it we should have an example of how it is used. Can you submit a replacement to clawpack/visclaw#144 that uses this?

I have this feeling that just creating gettime() function -- for now at least -- might result in less overhead. We eventually need to discuss how this object will fit with the existing Solution and Controller, which currently share responsibility for IO.

@mandli
Copy link
Member Author

mandli commented Feb 25, 2015

Ah sorry, forgot to issue the PR for that, fixed now.

@mandli
Copy link
Member Author

mandli commented Feb 26, 2015

I am thinking that perhaps this should be called IOController instead to indicate that it does not just deal with output. Any ideas?

@mandli mandli changed the title Add OutputController basic functionality WIP: Add OutputController basic functionality Feb 26, 2015
@mandli
Copy link
Member Author

mandli commented Mar 11, 2015

I am thinking that this is going to have some wide-ranging impacts and that perhaps we may want to move this to a CEP which we could write next week. In the mean time we can extract the essential content (again) and get the bux fix in there at least.

@mandli
Copy link
Member Author

mandli commented Mar 11, 2015

Proposed CEP8 related to this PR.

rjleveque added a commit that referenced this pull request Mar 19, 2015
WIP: Add `OutputController` basic functionality
@rjleveque rjleveque merged commit de1402d into clawpack:master Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants