Timestepping #510
Merged
Timestepping #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -163,7 +178,8 @@ def __init__(self,riemann_solver=None,claw_package=None): | |||
| self._is_set_up = False | |||
| self._use_old_bc_sig = False | |||
| self.accept_step = False | |||
| self.adjust_dt = False | |||
| self.get_dt = False | |||
| self.before_step = before_step | |||
There was a problem hiding this comment.
I believe this should be initialized to None to avoid wasting time on needless function calls.
There was a problem hiding this comment.
This is now initialized to None.
- Avoid dublicating code for selection of dt. - SSP22 SSP104 methods and get_dt routine do not return any variables. - Rename dq_dt to self.dq_dt and avoid computing function evaluation if previous step is rejected. - Rename self.dq_dt to self.prev_dq_dt_values. - self.before_step is initialized to None. - Use self.dt_old to check if we are at the first step or not.
|
This looks good to me now. @mandli since this is an internal refactoring and doesn't change anything that the average user should touch, is it okay with you if we sneak it into 5.3.0? If you think it is better we can wait for 5.3.1. |
|
I think that's fine with me. I would say merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a short PR that improves the time-stepping procedure in pyclaw.
It includes the following: