Revise 3rd-order LMM's step size condition for starting values. #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -204,8 +205,7 @@ def setup(self,solution): | |||
| self.num_ghost = (self.weno_order+1)/2 | |||
|
|
|||
| if self.lim_type == 2 and self.weno_order != 5 and self.kernel_language == 'Python': | |||
| raise Exception('Only 5th-order WENO reconstruction is implemented in Python kernels. \ | |||
| Use Fortran for higher-order WENO.') | |||
| raise Exception('Only 5th-order WENO reconstruction is implemented in Python kernels. Use Fortran for higher-order WENO.') | |||
There was a problem hiding this comment.
I don't think this pull request should change this message.
ketch
added a commit
that referenced
this pull request
Nov 24, 2015
Revise 3rd-order LMM's step size condition for starting values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is small fix to step size selection for 3rd order LMMs. Basically it allows bigger step sizes to be taken for starting values, unless the additional step size restrictions for 3rd order methods are violated.