Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable plotting from PETSc output files with serial Solution object. #538

Merged
merged 1 commit into from
May 10, 2016

Conversation

ketch
Copy link
Member

@ketch ketch commented May 10, 2016

This is needed because VisClaw always uses pyclaw.Solution rather
than petclaw.Solution. An alternative fix would be to modify
VisClaw, but that seems unnecessary and more tightly coupled.

This is needed because VisClaw always uses pyclaw.Solution rather
that petclaw.Solution.  An alternative fix would be to modify
VisClaw, but that seems unnecessary and more tightly coupled.
@coveralls
Copy link

coveralls commented May 10, 2016

Coverage Status

Changes Unknown when pulling f198e9f on ketch:bugfix_petsc_plotting into * on clawpack:master*.

@mandli
Copy link
Member

mandli commented May 10, 2016

I think I have run into this before and was part of the reason I was trying to make VisClaw respect the file_format (it does not do this consistently). I don't think I ever found all the places in VisClaw where this was the case though so if this fixes that I am all for this approach.

@ketch
Copy link
Member Author

ketch commented May 10, 2016

Yeah, I avoided this kind of thing before because I didn't want any petsc-related code in pyclaw itself (only in petclaw). But you don't usually want to load solutions in parallel, and if you do then this won't prevent you from doing so. This makes things simpler 99% of the time and seems easier than trying to make visclaw so aware of the different file formats.

@ketch ketch merged commit 40e1f82 into clawpack:master May 10, 2016
@ketch ketch removed the in progress label May 10, 2016
@ketch ketch deleted the bugfix_petsc_plotting branch May 10, 2016 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants