Add new gauges #541
Merged
Add new gauges #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is really meant to just stick the new gauge class into PyClaw since that's where it's going to end up anyway. I did take a look at what a preliminary implementation of replacing the current gauges in PyClaw would look like but it is a bit more complex than I had originally though about. Can we merge this PR and open an issue to incorporate these gauges into PyClaw for the time being? |
|
OK with me to merge, but perhaps @ketch disagrees? We need this to merge in a bunch of other changes in amrclaw and geoclaw. |
|
I'm fine with merging this in the interest of moving forward, especially since I don't expect to have time to make the changes in PyClaw soon. |
|
I will make the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new gauge solution class used by other clawpack repositories. See clawpack/clawpack#91 for the overarching commit.