Fix some issues with examples. #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketch
force-pushed
the
update_examples
branch
from
582bed3
to
71f9834
Compare
1. Automatically compile things (by calling Make) where necessary. 2. Use absolute imports for Python 3 compatibility. Also some miscellaneous fixes, like replacing spaces with tabs in a makefile.
ketch
force-pushed
the
update_examples
branch
from
71f9834
to
a40c235
Compare
|
The gallery builds fine now. Only the Python3 Travis tests are failing, so I guess we are ready to merge this and release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also some miscellaneous fixes, like replacing spaces with tabs in a makefile.
This avoids some errors that can appear when building the gallery, as noted by @rjleveque .