Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for the new MHD Roe solver #630

Merged
merged 5 commits into from
Oct 28, 2019
Merged

Conversation

ranocha
Copy link
Contributor

@ranocha ranocha commented Oct 16, 2019

This is a regression test for the MHD Roe solver implemented in clawpack/riemann/pull/155.

@ranocha ranocha mentioned this pull request Oct 16, 2019
@coveralls
Copy link

coveralls commented Oct 16, 2019

Coverage Status

Coverage remained the same at ?% when pulling 1bd079b on ranocha:mhd_roe into 2e9d3a7 on clawpack:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 5002e91 on ranocha:mhd_roe into 2e9d3a7 on clawpack:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 5002e91 on ranocha:mhd_roe into 2e9d3a7 on clawpack:master.

@ranocha
Copy link
Contributor Author

ranocha commented Oct 16, 2019

I wouldn't have expected the tests to pass since the new MHD Roe solver is not merged to clawpack/riemann yet. The tests on Travis do not seem to run the new example. Is this intended behavior?

@mandli
Copy link
Member

mandli commented Oct 16, 2019

It should be running it but it does not look like the test is being found. When you run nosetest does it find your test?

@ketch
Copy link
Member

ketch commented Oct 17, 2019

I think there was an issue with the example test I suggest you start with (oops!) I've opened a PR that I believe fixes this PR.

Correct MHD test file.
@ranocha
Copy link
Contributor Author

ranocha commented Oct 17, 2019

Thanks, @ketch! I've merged your PR.

@ketch
Copy link
Member

ketch commented Oct 17, 2019

Looks like I didn't fix it; it's still not picking up the test. I'll investigate.

@ketch
Copy link
Member

ketch commented Oct 28, 2019

I've made another PR to your branch (after actually testing it this time!)

Make MHD example importable.
@ranocha
Copy link
Contributor Author

ranocha commented Oct 28, 2019

Thanks! I've merged your PR.

@ketch ketch merged commit 92f8c74 into clawpack:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants