-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests for the new MHD Roe solver #630
Conversation
1 similar comment
I wouldn't have expected the tests to pass since the new MHD Roe solver is not merged to clawpack/riemann yet. The tests on Travis do not seem to run the new example. Is this intended behavior? |
It should be running it but it does not look like the test is being found. When you run |
I think there was an issue with the example test I suggest you start with (oops!) I've opened a PR that I believe fixes this PR. |
Correct MHD test file.
Thanks, @ketch! I've merged your PR. |
Looks like I didn't fix it; it's still not picking up the test. I'll investigate. |
I've made another PR to your branch (after actually testing it this time!) |
Make MHD example importable.
Thanks! I've merged your PR. |
This is a regression test for the MHD Roe solver implemented in clawpack/riemann/pull/155.