-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in 3.2.0: when source maps are enabled, the minified content changes #534
Comments
@hostep, thanks for giving it a try so quickly. It's interesting not a single test caught it - I'll find out why tomorrow morning. |
Flat blocks (`@font-face`) were omitted when adding optimization metadata, thus an important attribute was incorrectly added.
Ok thanks for the quick fix, I'll try it out later today. |
Thanks for such a quick fix! This caused one of our icon fonts to stop showing up in IE9 (guess it didn't like the important on a font-face src). Took me forever to figure out this was the issue though, lol. |
Thank you all for testing! With each release clean-css gets better thanks to 2.5k+ tests we have now. |
I noticed this happening with font-family, I didn't check if other properties are affected
Input:
When you clean this without source maps enabled, you get this:
@font-face{font-family:si}.soc-icon{font-family:si!important}
When you clean this with source maps enabled, you get this:
@font-face{font-family:'si'!important}.soc-icon{font-family:'si'!important}/*# sourceMappingURL=blahblah.css.map */
Notice the first
!important
which shouldn't be there and also the quotes around the font-familyThis didn't happen in 3.1.9
The text was updated successfully, but these errors were encountered: