Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

border-color merges too much aggressively #587

Closed
ogonkov opened this issue May 29, 2015 · 5 comments
Closed

border-color merges too much aggressively #587

ogonkov opened this issue May 29, 2015 · 5 comments
Labels

Comments

@ogonkov
Copy link

ogonkov commented May 29, 2015

clean-css break styles with reordering styles. tested on clean-css@3.2.10

.something-else {
    border-color: red;
}

.button {
    border: solid 1px;
}

.button_primary {
    color: #fff;
    background: red;
    border-color: red;
}

result:

.button_primary,.something-else{border-color:red}
.button{border:1px solid}
.button_primary{color:#fff;background:red}

Now .button_primary has broken border, instead of red.

@jakubpawlowicz
Copy link
Collaborator

Thanks @ogonkov for reporting this. I'll push a fix shortly!

@jakubpawlowicz
Copy link
Collaborator

Seems like a bug in restructuring - you can use --skip-restructuring switch in the meantime.

@jakubpawlowicz
Copy link
Collaborator

I pushed a fix to master which I plan to backport to 3.2 branch tomorrow and release a last maintenance version of it. It'll also go into 3.3 release should be out as soon as tomorrow.

@ogonkov
Copy link
Author

ogonkov commented May 30, 2015

Thank you, @jakubpawlowicz !

@jakubpawlowicz
Copy link
Collaborator

Re your question about border-image I thought it's not affected by border but in fact it is. I'll add a new commit however the rules will be slightly different.

jakubpawlowicz added a commit that referenced this issue May 31, 2015
Not all border reordering cases were covered correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants