Improve grammar and robustness and fix drill, see shellcheck.net #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graysky2
commented
Dec 15, 2019
graysky2
commented
- Mixed tabs/spaces all spaces
- https://github.com/koalaman/shellcheck/wiki/SC2002
- https://github.com/koalaman/shellcheck/wiki/SC2006
- https://github.com/koalaman/shellcheck/wiki/SC2086
|
Also fixed by newer PR #68 - so we might close this one?! @cleanbrowsing + @graysky2 |
|
@graysky2 , did you oversee my update regarding my newer PR? 🤔 |
|
Nope, it is unclear that upstream has an interest in this any more. |
graysky2
force-pushed
the
master
branch
2 times, most recently
from
f71a4d1
to
b9031bf
Compare
|
@thomasmerz - your PR does not fix #76 |
graysky2
changed the title
What a pity 😢 I wrote some emails directly to the maintainer, but without success as we can see… |
|
It's fine, one source becomes stable a new fork become active |
|
Yeah, but do you know a new active fork yet? 🤔 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.