[OSD] RSSI is always zero

[SandroGrzicic]

Latest (master) CF flashed to the OSD shows a RSSI of zero no matter what the actual RSSI is sent from the FC.

Looking at osdElementRender_rssi.c, we have:

uint16_t rssi = (uint16_t) dataFn();
tfp_sprintf(elementAsciiBuffer, "%3d", (rssi / 1023) * 100);

But rssi is always between 0 and 1000 since in msp_client_osd.c we have:

fcStatus.rssi = scaleRange(sbufReadU16(src), 0, 1023, 0, 1000);

So won't any rssi between 0 and 1000 after being divided by 1023 be zero?

Since rssi is 0 to 1000, isn't it enough to have:

tfp_sprintf(elementAsciiBuffer, "%3d", rssi / 10);

?

See 058e9da

I have changed the above calculation to rssi / 10 and now RSSI is showing up properly in the OSD.

[hydra]

yes, this was due to unmerged changes for the spracingf3neo board support which handled this differently. Likely we will need to address this again when that branch is merged in.

[hydra]

See #2517

[SandroGrzicic]

Since my PR has been merged I'll close this issue, a new one can be raised if there is any RSSI issue later on.

[hydra]

see cb6c861