-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smartport: added MSP/SPORT bridge #2504
Conversation
Another thing: the build fails with NAZE only, because of that:
Any suggestion how to solve it? Should it be made optional? I have no idea what should be done here. |
yes, make it optional. Current there are SKIP_* and USE_* defines. We prefer USE_*. So please add USE_SMARTPORT_MSP_BRIDGE. Then edit the makefile and add a section to add USE_SMARTPORT_BRIDGE for all F3 targets. There's an example of this at around 224-234. All the F1 targets are space limited. Unless you prefer adding 'USE_SMARTPORT_MSP_BRIDGE' to each F3 target.h file? Other suggestions welcomed. Pick one at your discretion, we can always change that bit later anyway, not critical. Please perform some testing too. |
@hydra the current head of master does not fit either into NAZE target:
However, with the current modifications to smartport (MSP bridge OFF), I get 20 bytes back. |
952667a
to
13de792
Compare
I've tested it on SPRACINGF3EVO + opentx 2.2 + LUA script, and it works just fine. Some modifications might still be needed to better adapt the LUA script to cleanflight's rate settings (had some troubles first understanding how they work). |
This new feature allows for using the MSP interface over smart port, for example from a LUA script. implements betaflight#2474
13de792
to
bb363ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
files changed
Is this code up to date? have there been any more changes in BF that need merging in with this PR? |
Hi @hydra! Nope, the code in smartport.c has been pretty stable and working steadily. Did you try it out? I'm not 100% sure I've understood the configuration in cleanflight correctly. If you get the chance, it would be good if you could have a try at the LUA script and see if the values are used/interpreted correctly. |
@raphaelcoeffic which part of the configuration are you struggling with? |
The rates, I think it's different from BF.
… On 5 Feb 2017, at 14:25, Dominic Clifton ***@***.***> wrote:
@raphaelcoeffic which part of the configuration are you struggling with?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Added PG config definitions 9
This new feature allows for using the MSP interface over smart port, for example from a LUA script.
Please note that it has not been tested with cleanflight, only with betaflight. I need to shrink the naze target first, so that I can test it on my devel board.
This PR is related to issue #2474.