Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

versions: Update recommended golang version. #1086

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

jcvenegas
Copy link
Contributor

Clear Containers CI uses go 1.9.4

Fixes: #1085

Signed-off-by: Jose Carlos Venegas Munoz jose.carlos.venegas.munoz@intel.com

Clear Containers CI uses go 1.9.4

Fixes: clearcontainers#1085

Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
@grahamwhaley
Copy link
Contributor

Ubuntu CI failed - quick look at logs didn't show immediately why?

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Please check the failing CI

@jcvenegas
Copy link
Contributor Author

@devimc ready to merge

@jodh-intel
Copy link
Contributor

jodh-intel commented Apr 3, 2018

lgtm

Approved with PullApprove Approved with PullApprove

@jodh-intel
Copy link
Contributor

Actually, there are a couple of issues here:

In summary:

  • we're building packages with a very old version of go
  • we're recommending developers build with an old version of go (but newer than the packaging version).
  • we're testing with a newer (but not the latest) version of go.

We have a plan for how to resolve this for Kata but it's something we should be aware of I think:

/cc @sboeuf, @markdryan.

@jcvenegas
Copy link
Contributor Author

@jodh-intel yes, that is one of the issues I see, first I want to reflect here the version we use to test. Today is not easy to test in the CI to a new golang version to check all works as expected. I added an script here
clearcontainers/tests@af4ad93 to allow change golang.

I require golang 1.10+ to allow cri-containerd in our CI.

@jodh-intel
Copy link
Contributor

Nice - that would be useful in kata too. Let's merge this one then as a first-pass...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants