Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #96

Merged
2 commits merged into from
May 21, 2015
Merged

Update README.md #96

2 commits merged into from
May 21, 2015

Conversation

perguth
Copy link
Contributor

@perguth perguth commented Apr 30, 2015

Provided the combined install command for convenience.

Provided the combined install command for convenience.
@perguth
Copy link
Contributor Author

perguth commented Apr 30, 2015

Maybe also include qt4-linguist-tools right away (Issue #85)?

@ghost
Copy link

ghost commented May 1, 2015

@pguth
Thanks again for your suggestion.

I had revised the Wiki some time ago, and the dependency has been included already in the instructions on both--First guide (for dpkg method) and Installation (for alternative methods) pages.

Since you had already include a link to the First guide page, perhaps adding the missing dependency qt4-linguist-tools under "REQUIREMENTS" in the README.md would suffice.

@ghost
Copy link

ghost commented May 2, 2015

As for the install command, there is an error in your commit (sudo apt-get install appeared twice--why?).

You can either copy the correct install command from point no. 2 of First guide, or for your convenience, I have copy-pasted as below:

sudo apt-get install git build-essential fakeroot make binutils g++ python python-dev python-qt4 pyqt4-dev-tools squashfs-tools xorriso x11-xserver-utils xserver-xephyr qemu-kvm dpkg-dev debhelper qt4-dev-tools qt4-linguist-tools --no-install-recommends

The --no-install-recommends is included because some user wants to install only minimal packages. Whether you want to include or not in the README.md, is up to you.

@perguth
Copy link
Contributor Author

perguth commented May 19, 2015

@clearkimura Just swapped my apt-get line for yours. Thanks!

ghost pushed a commit that referenced this pull request May 21, 2015
@ghost ghost merged commit f45d7e4 into kamilion:master May 21, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant