This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Add capability to declare specific attribute #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: VictorRodriguez <vm.rod25@gmail.com>
|
@zerodefect could you please help me to take a look at this PR , I am not an expert in Perl , let me know if it does not break the test ( I have already test it , but an extra eyes on this might be good ) |
|
Yes, I'll try it out by the end of the day tomorrow. Happy to help. |
Co-Authored-By: VictorRodriguez <victor.rodriguez.bahena@intel.com>
|
You beat me to it. I've just tried it this evening. It works :) |
|
Sorry @zerodefect my apologies, next time I will wait until your confirmation |
|
I don't mind :) I thought you were waiting on me, so I didn't want you to think that I had forgotten about it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to provide a common fix for #8
Signed-off-by: VictorRodriguez vm.rod25@gmail.com