Plonk: transcript hasher #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vesselinux please rebase onto origin/develop |
Sorry, do you mean rebase onto origin/plonk? |
Oh yes. origin/plonk please. Thanks. |
dtebbs
suggested changes
Jul 29, 2022
vesselinux
force-pushed
the
plonk-transcript-hasher-issue-56
branch
2 times, most recently
from
ef3297b
to
ee34c38
Compare
Rebased on |
dtebbs
reviewed
Aug 2, 2022
dtebbs
reviewed
Aug 2, 2022
vesselinux
pushed a commit
that referenced
this pull request
Aug 16, 2022
vesselinux
pushed a commit
that referenced
this pull request
Aug 17, 2022
vesselinux
force-pushed
the
plonk-transcript-hasher-issue-56
branch
from
793e649
to
2fbad61
Compare
vesselinux
pushed a commit
that referenced
this pull request
Aug 17, 2022
vesselinux
force-pushed
the
plonk-transcript-hasher-issue-56
branch
from
2fbad61
to
78dd119
Compare
vesselinux
pushed a commit
that referenced
this pull request
Aug 17, 2022
…to the transcript hasher constructor (cf. #61 (comment)); added exception handling in case the buffer length is invalid (cf. #61 (comment))
dtebbs
reviewed
Aug 18, 2022
vesselinux
pushed a commit
that referenced
this pull request
Aug 18, 2022
…r process since u is not used by the prover anyway. removed the automatic clearing of the hasher buffer inside get_hash. the caller is now responsible to clear the buffer when reusing the same hasher object. see also PR comment #61 (comment) .
dtebbs
reviewed
Aug 19, 2022
dtebbs
reviewed
Aug 19, 2022
vesselinux
pushed a commit
that referenced
this pull request
Aug 19, 2022
vesselinux
pushed a commit
that referenced
this pull request
Aug 19, 2022
… the class. addresses #61 (comment)
|
Hasher should either keep a reference (more dangerous), or just allocate it's own internal buffer. Latter is probably preferable. |
vesselinux
pushed a commit
that referenced
this pull request
Aug 26, 2022
…e last round of the prover. we need to compute u even though we are not using it in the prover in order to make sure that the prover and verifier make exactly the same number of calls to transcript_hasher.get_hash(). addresses PR #61 comment #61 (comment)
vesselinux
pushed a commit
that referenced
this pull request
Aug 26, 2022
… input parameter to the constructor. only the object has access to the buffer now. addresses PR #61 comment #61 (comment)
Removed the private buffer variable as an input parameter to the constructor. Only the object has access to the buffer now. |
vesselinux
pushed a commit
that referenced
this pull request
Oct 13, 2022
vesselinux
pushed a commit
that referenced
this pull request
Oct 13, 2022
…ion parameter to the prover and verifier classes. moved the current transcript_hasher class from files srs.* to its own files under tests, the reason being that its implementation is specific to the bls12-381 curve. set the prover and verifier to be instantiated with this bls12-381-specific implementation of transcript_hasher. this commit addresses steps 2. and 4. from comment #61 (comment) of PR#61.
vesselinux
pushed a commit
that referenced
this pull request
Oct 13, 2022
…hat describes the interface of a common transcript hasher. addresses step 1. from comment #61 (comment) of PR#61.
vesselinux
pushed a commit
that referenced
this pull request
Oct 13, 2022
…cript hasher with a while loop directly finding the correct length; addresses #61 (comment) .
vesselinux
pushed a commit
that referenced
this pull request
Oct 13, 2022
vesselinux
pushed a commit
that referenced
this pull request
Oct 13, 2022
vesselinux
pushed a commit
that referenced
this pull request
Oct 13, 2022
…tor_transcript_hasher::get_hash(). addresses #61 (comment) .
vesselinux
pushed a commit
that referenced
this pull request
Oct 13, 2022
vesselinux
pushed a commit
that referenced
this pull request
Oct 13, 2022
…bls12_381_test_vector_transcript_hasher initialized in the constructor. addresses #61 (comment) .
vesselinux
pushed a commit
that referenced
this pull request
Oct 13, 2022
vesselinux
pushed a commit
that referenced
this pull request
Oct 13, 2022
…length and challenge arrays are of same length in transcript hasher constructor; minor edits. addresses lates comments in PR #61 .
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
…to the transcript hasher constructor (cf. #61 (comment)); added exception handling in case the buffer length is invalid (cf. #61 (comment))
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
…r process since u is not used by the prover anyway. removed the automatic clearing of the hasher buffer inside get_hash. the caller is now responsible to clear the buffer when reusing the same hasher object. see also PR comment #61 (comment) .
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
… the class. addresses #61 (comment)
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
…e last round of the prover. we need to compute u even though we are not using it in the prover in order to make sure that the prover and verifier make exactly the same number of calls to transcript_hasher.get_hash(). addresses PR #61 comment #61 (comment)
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
… input parameter to the constructor. only the object has access to the buffer now. addresses PR #61 comment #61 (comment)
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
… plonk_example class; addresses #61 (comment) .
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
…ion parameter to the prover and verifier classes. moved the current transcript_hasher class from files srs.* to its own files under tests, the reason being that its implementation is specific to the bls12-381 curve. set the prover and verifier to be instantiated with this bls12-381-specific implementation of transcript_hasher. this commit addresses steps 2. and 4. from comment #61 (comment) of PR#61.
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
…hat describes the interface of a common transcript hasher. addresses step 1. from comment #61 (comment) of PR#61.
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
…cript hasher with a while loop directly finding the correct length; addresses #61 (comment) .
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
…tor_transcript_hasher::get_hash(). addresses #61 (comment) .
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
…bls12_381_test_vector_transcript_hasher initialized in the constructor. addresses #61 (comment) .
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
dtebbs
pushed a commit
that referenced
this pull request
Oct 26, 2022
…length and challenge arrays are of same length in transcript hasher constructor; minor edits. addresses lates comments in PR #61 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #56