-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plonk: transcript hasher #61
Commits on Sep 12, 2022
-
plonk: replaced structure transcript_hash_t with class transcript_has…
…her that makes a call to hash function. for the moment it directly returns the expected hash values for the purposes of testing. addresses issue #56.
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for cfee874 - Browse repository at this point
Copy the full SHA cfee874View commit details -
plonk: implementation of transcript hasher, addressing issue #56 and PR
#61.
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for 138edec - Browse repository at this point
Copy the full SHA 138edecView commit details -
plonk: moved the initialisation of the array of expected hash values …
…to the transcript hasher constructor (cf. #61 (comment)); added exception handling in case the buffer length is invalid (cf. #61 (comment))
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for 55fb227 - Browse repository at this point
Copy the full SHA 55fb227View commit details -
plonk: removed catching the invalid size exception within the get_has…
…h function. the caller must handle it.
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for e6415bf - Browse repository at this point
Copy the full SHA e6415bfView commit details -
plonk: removed computation of the challenge u at the end of the prove…
…r process since u is not used by the prover anyway. removed the automatic clearing of the hasher buffer inside get_hash. the caller is now responsible to clear the buffer when reusing the same hasher object. see also PR comment #61 (comment) .
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for b6cb38e - Browse repository at this point
Copy the full SHA b6cb38eView commit details -
plonk: use std::count to check if the hasher buffer is of valid lengt…
…h instead of explicitly checking all valid lengths.
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for 7a9483a - Browse repository at this point
Copy the full SHA 7a9483aView commit details -
plonk: removed doc comments /// from cpp and tcc files. left only in …
…headers. addresses #61 (comment)
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for 91e7bb2 - Browse repository at this point
Copy the full SHA 91e7bb2View commit details -
plonk: moved constructor of transcipt_hasher class as first method in…
… the class. addresses #61 (comment)
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for e751e98 - Browse repository at this point
Copy the full SHA e751e98View commit details -
plonk: added back the computation of the multipoint challenge u in th…
…e last round of the prover. we need to compute u even though we are not using it in the prover in order to make sure that the prover and verifier make exactly the same number of calls to transcript_hasher.get_hash(). addresses PR #61 comment #61 (comment)
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for c4dccd1 - Browse repository at this point
Copy the full SHA c4dccd1View commit details -
plonk: in transcript_hasher removed the private buffer variable as an…
… input parameter to the constructor. only the object has access to the buffer now. addresses PR #61 comment #61 (comment)
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for b42bc2a - Browse repository at this point
Copy the full SHA b42bc2aView commit details -
plonk: moved function signature comments from .tcc to .hpp files only…
…; removed redundant comments indicating class constructors' other minor comments formatting
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for d8bdc13 - Browse repository at this point
Copy the full SHA d8bdc13View commit details -
plonk: replaced test values in transcript_hasher with values from the…
… plonk_example class; addresses #61 (comment) .
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for dcb5ce8 - Browse repository at this point
Copy the full SHA dcb5ce8View commit details -
plonk: removed redundant debug info and unreachable debug checks. add…
…resses PR# 61.
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for bc297b9 - Browse repository at this point
Copy the full SHA bc297b9View commit details -
plonk: set transcript hasher constants alpha, beta, ... to type const…
…. see PR #61
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for 64069a0 - Browse repository at this point
Copy the full SHA 64069a0View commit details -
plonk: added the transcript_hasher class as an additional specializat…
…ion parameter to the prover and verifier classes. moved the current transcript_hasher class from files srs.* to its own files under tests, the reason being that its implementation is specific to the bls12-381 curve. set the prover and verifier to be instantiated with this bls12-381-specific implementation of transcript_hasher. this commit addresses steps 2. and 4. from comment #61 (comment) of PR#61.
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for b8665f2 - Browse repository at this point
Copy the full SHA b8665f2View commit details -
plonk: created a new transcript_hasher.hpp file with just a comment t…
…hat describes the interface of a common transcript hasher. addresses step 1. from comment #61 (comment) of PR#61.
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for b423eec - Browse repository at this point
Copy the full SHA b423eecView commit details -
plonk: replaced the checks over all valid buffer lengths in the trans…
…cript hasher with a while loop directly finding the correct length; addresses #61 (comment) .
Vesselin Velichkov committedSep 12, 2022 Configuration menu - View commit details
-
Copy full SHA for 0fbd9ab - Browse repository at this point
Copy the full SHA 0fbd9abView commit details
Commits on Sep 13, 2022
-
plonk: replaced challenge_str map with a vector. addresses #61 (comment)
Vesselin Velichkov committedSep 13, 2022 Configuration menu - View commit details
-
Copy full SHA for 0508ed5 - Browse repository at this point
Copy the full SHA 0508ed5View commit details -
plonk: combine two error checks that are functionally the same into o…
…ne. addresses #61 (comment) .
Vesselin Velichkov committedSep 13, 2022 Configuration menu - View commit details
-
Copy full SHA for 5f62026 - Browse repository at this point
Copy the full SHA 5f62026View commit details -
plonk: declared const challenge upon assignment in bls12_381_test_vec…
…tor_transcript_hasher::get_hash(). addresses #61 (comment) .
Vesselin Velichkov committedSep 13, 2022 Configuration menu - View commit details
-
Copy full SHA for 9453d58 - Browse repository at this point
Copy the full SHA 9453d58View commit details -
plonk: removed redundant this-> in get_hash. addresses #61 (comment) .
Vesselin Velichkov committedSep 13, 2022 Configuration menu - View commit details
-
Copy full SHA for 2979026 - Browse repository at this point
Copy the full SHA 2979026View commit details -
plonk: created length and challenge arrays as const members of class …
…bls12_381_test_vector_transcript_hasher initialized in the constructor. addresses #61 (comment) .
Vesselin Velichkov committedSep 13, 2022 Configuration menu - View commit details
-
Copy full SHA for d923414 - Browse repository at this point
Copy the full SHA d923414View commit details
Commits on Sep 14, 2022
-
plonk: amended comments to transcript hasher code according to sugges…
…tions in #61 (comment) .
Vesselin Velichkov committedSep 14, 2022 Configuration menu - View commit details
-
Copy full SHA for 5e49971 - Browse repository at this point
Copy the full SHA 5e49971View commit details
Commits on Sep 15, 2022
-
plonk: replaced while loop in get_hash with for loop; assert-ed that …
…length and challenge arrays are of same length in transcript hasher constructor; minor edits. addresses lates comments in PR #61 .
Vesselin Velichkov committedSep 15, 2022 Configuration menu - View commit details
-
Copy full SHA for 92e7806 - Browse repository at this point
Copy the full SHA 92e7806View commit details
Commits on Sep 16, 2022
-
plonk: renamed example.tcc to example.cpp. added example.cpp and bls1…
…2_381_test_vector_transcript_hasher.cpp to CMakeLists.txt. added several headers to fix compilation errors.
Vesselin Velichkov committedSep 16, 2022 Configuration menu - View commit details
-
Copy full SHA for a30695f - Browse repository at this point
Copy the full SHA a30695fView commit details