libzeth: fix json output of pghr13 proofs #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -117,7 +117,17 @@ template<typename ppT> | |||
| std::ostream &pghr13_snark<ppT>::proof_write_json( | |||
| const typename pghr13_snark<ppT>::ProofT &proof, std::ostream &os) | |||
| { | |||
| return os << proof; | |||
| os << "{\n"; | |||
| os << " \"a\" :[" << point_g1_affine_to_json<ppT>(proof.g_A.g) << "],\n"; | |||
There was a problem hiding this comment.
I don't think you need the surrounding [ and ] here as these are already added in the point_g1_affine_to_json functions which write the group elements as an array of hex string https://github.com/clearmatics/zeth/blob/master/libzeth/core/group_element_utils.tcc#L18
There was a problem hiding this comment.
Thanks. I restored it from the old code and forgot to fix this. Should be updated now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pghr13
proof_write_jsonfunnction, which was using the default stream operator (which produces binary by default).