Improved encoding of objects passed to web3 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtebbs
force-pushed
the
precompiled-contracts
branch
from
aaaf2cf
to
23f160c
Compare
dtebbs
force-pushed
the
evm-encoding
branch
from
9dc0026
to
0c38b29
Compare
dtebbs
changed the title
dtebbs
force-pushed
the
precompiled-contracts
branch
2 times, most recently
from
e8eabc4
to
c07e2f1
Compare
dtebbs
force-pushed
the
evm-encoding
branch
from
82cc580
to
afe76e8
Compare
AntoineRondelet
changed the base branch from
precompiled-contracts
to
develop
dtebbs
changed the title
dtebbs
changed the title
…s for various pairings
dtebbs
force-pushed
the
evm-encoding
branch
from
0f25bce
to
524ae79
Compare
|
LGTM |
AntoineRondelet
added a commit
that referenced
this pull request
Oct 2, 2020
Negate groth16 b (depends on #283)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encode verification keys, proofs and input values into evm words. This PR:
(Depends on #280)
Note, there is still room for stronger types around the handling of keys and proofs in python.
This should be addressed in a future PR.