Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full support for BLS12-377 (depends on #302) #298

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Oct 12, 2020

Changes required to execute zeth using BLS12-377 in zk-proofs.

  • Contracts: BLS12_377MixerBase and Groth16BLS12_377Mixer
  • Enable BLS curve for all mixing tests
  • Curve configuration handling in mpc tools

Related spec changes: clearmatics/zeth-specifications#1 clearmatics/zeth-specifications#4

@dtebbs dtebbs force-pushed the bls12-377-verifier branch 2 times, most recently from 489690d to dfe0f73 Compare October 12, 2020 15:32
@dtebbs dtebbs force-pushed the bls12-377-verifier branch 2 times, most recently from e033053 to b2f29a4 Compare October 16, 2020 16:52
@dtebbs dtebbs changed the base branch from bls12-377-verifier to client-mixer-tidy October 20, 2020 10:16
@dtebbs dtebbs force-pushed the zeth-bls12-377 branch 2 times, most recently from 768ab3d to 0ae5a11 Compare October 20, 2020 11:23
@dtebbs dtebbs force-pushed the client-mixer-tidy branch 2 times, most recently from 3685378 to c4a4ed3 Compare October 29, 2020 18:45
@dtebbs dtebbs force-pushed the zeth-bls12-377 branch 5 times, most recently from 2a5ae94 to ade47d6 Compare November 2, 2020 18:42
@dtebbs dtebbs force-pushed the client-mixer-tidy branch 5 times, most recently from 7f23176 to b5b147a Compare November 9, 2020 10:31
@dtebbs dtebbs force-pushed the zeth-bls12-377 branch 2 times, most recently from 2159fae to 2c96814 Compare November 9, 2020 11:15
@dtebbs dtebbs changed the title WIP: switch to bls12-377 in prover_server, client and contract WIP: Full support for BLS12-377 Nov 9, 2020
@dtebbs dtebbs changed the title WIP: Full support for BLS12-377 WIP: Full support for BLS12-377 (depends on #302) Nov 9, 2020
@dtebbs dtebbs changed the title WIP: Full support for BLS12-377 (depends on #302) Full support for BLS12-377 (depends on #302) Nov 9, 2020
@dtebbs dtebbs force-pushed the client-mixer-tidy branch 2 times, most recently from f4151a5 to f6c17d5 Compare November 24, 2020 18:31
@AntoineRondelet AntoineRondelet changed the base branch from client-mixer-tidy to develop November 25, 2020 17:35
@dtebbs dtebbs force-pushed the zeth-bls12-377 branch 2 times, most recently from 6b313e6 to 5698372 Compare November 26, 2020 09:57
zeth_contracts/contracts/BLS12_377MixerBase.sol Outdated Show resolved Hide resolved
zeth_contracts/contracts/BLS12_377MixerBase.sol Outdated Show resolved Hide resolved
zeth_contracts/contracts/BLS12_377MixerBase.sol Outdated Show resolved Hide resolved
zeth_contracts/contracts/BLS12_377MixerBase.sol Outdated Show resolved Hide resolved
@AntoineRondelet
Copy link
Contributor

Related spec changes: clearmatics/zeth-specifications#1 clearmatics/zeth-specifications#4

Great to have a reference to the specs to review new code 💪

Copy link
Contributor

@AntoineRondelet AntoineRondelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the final touches - thanks @dtebbs

@AntoineRondelet AntoineRondelet merged commit 1de8b41 into develop Dec 3, 2020
@AntoineRondelet AntoineRondelet deleted the zeth-bls12-377 branch December 21, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants