Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up some cmake files #47

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Tidy up some cmake files #47

merged 1 commit into from
Aug 14, 2019

Conversation

dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Aug 12, 2019

Addresses #46

@dtebbs dtebbs changed the title Tidy up some cmake files #46 Tidy up some cmake files Aug 12, 2019
@AntoineRondelet
Copy link
Contributor

Let's look at #50 first and merge this one after the resolution of the problem with test_prover and libboost.

@dtebbs
Copy link
Contributor Author

dtebbs commented Aug 13, 2019

Let's look at #50 first and merge this one after the resolution of the problem with test_prover and libboost.

Yes. Sorry about that. For some reason, I didn't need to link boost_system on my machine (mac difference, maybe), so I didn't include it.
I pushed a slightly different way of specifying the boost_system dependency, but feel free to force-push or replace with your PR if you prefer.

@AntoineRondelet
Copy link
Contributor

I pushed a slightly different way of specifying the boost_system dependency, but feel free to force-push or replace with your PR if you prefer.

Have you pushed on this branch? I can't see any new commits to link boost_system

@AntoineRondelet AntoineRondelet added the build Task related to the compilation and execution of the project label Aug 13, 2019
@dtebbs
Copy link
Contributor Author

dtebbs commented Aug 14, 2019

Sorry, the push didn't work. Should be there now.

@AntoineRondelet AntoineRondelet merged commit 4051b98 into develop Aug 14, 2019
@AntoineRondelet AntoineRondelet deleted the cmake-tidy branch August 15, 2019 11:18
AntoineRondelet added a commit that referenced this pull request May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Task related to the compilation and execution of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants