Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies in cmake files #46

Closed
dtebbs opened this issue Aug 12, 2019 · 1 comment
Closed

Dependencies in cmake files #46

dtebbs opened this issue Aug 12, 2019 · 1 comment

Comments

@dtebbs
Copy link
Contributor

dtebbs commented Aug 12, 2019

Source file and dependency specifications seem to suffer from a few problems:

  • source files are re-specified for every executable (utility and unit test) which inflates build times
  • some include files and .tcc files are not specified as belonging to any target which means that incremental builds (using Makefiles) are often incomplete.
dtebbs added a commit that referenced this issue Aug 12, 2019
@dtebbs
create libzeth of common code and clean executable specs #46
3d08b61
@dtebbs dtebbs mentioned this issue Aug 12, 2019
Merged
dtebbs added a commit that referenced this issue Aug 12, 2019
@dtebbs
Merge branch 'cmake-tidy' into mpc
a11210c 
* cmake-tidy:
  create libzeth of common code and clean executable specs  #46
dtebbs added a commit that referenced this issue Aug 12, 2019
@dtebbs
create libzeth of common code and clean executable specs #46
188e758
dtebbs added a commit that referenced this issue Aug 14, 2019
@dtebbs
create libzeth of common code and clean executable specs #46
1240aa4
@AntoineRondelet
Copy link
Contributor

Closed as the corresponding PR has been merged.
Thanks for that @dtebbs

AntoineRondelet pushed a commit that referenced this issue May 6, 2020
@dtebbs
create libzeth of common code and clean executable specs #46
fc67c3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dtebbs @AntoineRondelet