Blake2s review #81
Merged
Blake2s review #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added comments where needed, used variables/const where necessary and cleaned a few formatting issues. |
…tants where needed
AntoineRondelet
force-pushed
the
blake2s-review
branch
from
258d2f4
to
cbc1976
Compare
Merged
rrtoledo
reviewed
Oct 1, 2019
rrtoledo
reviewed
Oct 1, 2019
AntoineRondelet
force-pushed
the
blake2s-review
branch
from
3bf5723
to
23fd6fe
Compare
rrtoledo
approved these changes
Oct 2, 2019
AntoineRondelet
added a commit
that referenced
this pull request
May 6, 2020
* Used constants where needed, refered to the specs and used class constructors * Fixed comments for the gadgets and modified the XOR constraint * Refactored the XOR gadgets and added comments to explain constraints * Switched sign in XOR rot gadget * Fixed formatting, added comments to refer to the specs and added constants where needed * Commented the xor gadgets * Fixed comments formatting * Declared and used state constants * Ran formatting tool * Fixed sign error in constraint comment * Fixed build by adding workaround for const std::array attribute declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.