Blake2s update #63

rrtoledo · 2019-08-23T14:10:24Z

No description provided.

AntoineRondelet · 2019-08-27T11:28:45Z

This PR tackles issue #49

pyClient/zethGRPC.py

src/circuits/blake2s/blake2s_comp.hpp

src/circuits/blake2s/blake2s_setup.tcc

src/circuits/circuits-util.tcc

src/test/prfs_test.cpp

src/test/sha256_test.cpp

src/test/simple_gadget_test.cpp

src/types/bits.tcc

src/circuits/blake2s/blake2s_comp.tcc

AntoineRondelet

Please answer the questions that have been asked and mark the discussions as "resolved" when comments are addressed so that we can track the progress being made on the PR @rrtoledo

src/test/sha256_test.cpp

src/test/mimc_test.cpp

src/circuits/joinsplit.tcc

AntoineRondelet · 2019-10-01T08:24:09Z

@rrtoledo I did some cleanup and documentation of the code here: #81

* Used constants where needed, refered to the specs and used class constructors * Fixed comments for the gadgets and modified the XOR constraint * Refactored the XOR gadgets and added comments to explain constraints * Switched sign in XOR rot gadget * Fixed formatting, added comments to refer to the specs and added constants where needed * Commented the xor gadgets * Fixed comments formatting * Declared and used state constants * Ran formatting tool * Fixed sign error in constraint comment * Fixed build by adding workaround for const std::array attribute declaration

src/test/commitments_test.cpp

src/circuits/circuits-util.tcc

src/test/blake2s_test.cpp

src/test/prover_test.cpp

src/circuits/binary_operation_gadgets.hpp

src/test/blake2s_test.cpp

src/CMakeLists.txt

src/test/blake2s_test.cpp

Blake cleanup

Blake2s update

AntoineRondelet and others added 2 commits September 11, 2019 11:30

BLAKE2s Update

7f886d7

fixing comments

2e67b78

rrtoledo force-pushed the blake2s branch from ecbad91 to 2e67b78 Compare September 11, 2019 15:43

rrtoledo added 6 commits September 12, 2019 10:07

Merge branch 'develop' into blake2s

1352a5e

formatting

9fe265c

remove deprecated char*

719b510

formatting

5d5d634

merging mimc tests

63d74bc

fixing comment and using var instead of hardcoded constant

015c288

rrtoledo changed the title ~~[WIP] Blake2s update~~ Blake2s update Sep 16, 2019

AntoineRondelet self-requested a review September 16, 2019 10:09

AntoineRondelet reviewed Sep 16, 2019

View reviewed changes

src/circuits/blake2s/blake2s_comp.tcc Outdated Show resolved Hide resolved

rrtoledo added 2 commits September 24, 2019 18:12

fixing comments, function names and so on

2a49aab

formatting

e984b6f

AntoineRondelet reviewed Sep 30, 2019

View reviewed changes

src/test/sha256_test.cpp Outdated Show resolved Hide resolved

src/test/mimc_test.cpp Outdated Show resolved Hide resolved

src/circuits/joinsplit.tcc Outdated Show resolved Hide resolved

rrtoledo added 2 commits September 30, 2019 16:37

modifying comments

5a1c016

formatting

fe75515

AntoineRondelet and others added 5 commits October 2, 2019 14:37

renaming file, removing sha256 fix (will be in another PR)

8b58848

formatting

462c712

removing changes done to mimc test (now part of new issue)

ac354cb

Trigger travis

78604bd

AntoineRondelet reviewed Oct 16, 2019

View reviewed changes

src/test/commitments_test.cpp Outdated Show resolved Hide resolved

AntoineRondelet reviewed Oct 16, 2019

View reviewed changes

src/test/commitments_test.cpp Outdated Show resolved Hide resolved

rrtoledo commented Oct 16, 2019

View reviewed changes

src/circuits/circuits-util.tcc Show resolved Hide resolved

fixing comments, trying to reformat some

a700d12

AntoineRondelet reviewed Oct 16, 2019

View reviewed changes

src/test/blake2s_test.cpp Outdated Show resolved Hide resolved

rrtoledo commented Oct 16, 2019

View reviewed changes

src/test/prover_test.cpp Outdated Show resolved Hide resolved

rrtoledo added 2 commits October 16, 2019 14:40

adding details of test vector in blake2s_test, fixing comment

8f19d5a

fixing comment

abdb8c4

AntoineRondelet reviewed Oct 16, 2019

View reviewed changes

src/circuits/binary_operation_gadgets.hpp Outdated Show resolved Hide resolved

src/test/blake2s_test.cpp Show resolved Hide resolved

fixing file ifdef

e05c7f7

AntoineRondelet reviewed Oct 17, 2019

View reviewed changes

src/CMakeLists.txt Outdated Show resolved Hide resolved

rrtoledo and others added 10 commits October 17, 2019 12:54

cleaning up commentsgit status

308815a

cleaning up ifndef (removing _circuits)

e3d6dbe

fixing ifndef (type_ needed for similar named files)

873a084

changing ifndef convention, adding /// back

daeca5a

adding missing hpp

dd8e93d

renaming file, correcting indentation

d0924c0

forgot to add tests

3c3934b

changing include order

4d39df1

adding space between includes

8d0410e

Fixed the build

a276d7f

AntoineRondelet reviewed Oct 21, 2019

View reviewed changes

src/test/blake2s_test.cpp Show resolved Hide resolved

AntoineRondelet and others added 2 commits October 21, 2019 09:57

Merge pull request #87 from clearmatics/blake_cleanup

2b25f34

Blake cleanup

adding information about test vectors for blake2s tests

8f8f61f

AntoineRondelet merged commit 27296bc into develop Oct 21, 2019

rrtoledo deleted the blake2s branch October 25, 2019 09:59

AntoineRondelet added a commit that referenced this pull request May 6, 2020

Merge pull request #63 from clearmatics/blake2s

4edcf8a

Blake2s update

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Blake2s update #63

Blake2s update #63

rrtoledo commented Aug 23, 2019

AntoineRondelet commented Aug 27, 2019

AntoineRondelet left a comment

AntoineRondelet commented Oct 1, 2019

Blake2s update #63

Blake2s update #63

Conversation

rrtoledo commented Aug 23, 2019

AntoineRondelet commented Aug 27, 2019

AntoineRondelet left a comment

Choose a reason for hiding this comment

AntoineRondelet commented Oct 1, 2019