Enable customization of After= in service #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 27, 2021 15:00
This feature enables the user to define the services after which the generated service will. This is handy when hardware-related system services have to start before the ROS software.
|
@mikepurvis Could I have some feedback on this, please |
tonybaltovski
approved these changes
May 12, 2021
|
Thanks @yotabits |
tonybaltovski
pushed a commit
that referenced
this pull request
May 12, 2021
* Cosmetic Remove unnecessary parenthesis. * Correct typo * FIX: Remove unreachable code * Enable customizable After= in service This feature enables the user to define the services after which the generated service will. This is handy when hardware-related system services have to start before the ROS software.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enables the user to define the services after which the generated
service will. This is handy when hardware-related system services have
to start before the ROS software.