Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wait flag in the install script #73

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Add support for wait flag in the install script #73

merged 2 commits into from
Jul 19, 2019

Conversation

msadowski
Copy link
Contributor

Hi!

I run into some cases where I need to pass the wait flag to the roslaunch. This merge request adds a "--wait" option that will change the job.roslaunch_wait that was already implemented.

Please let me know if there is anything else you would like to see changed.

@130s
Copy link
Contributor

130s commented Jul 18, 2019

+1

@winchesterag and I are discussing adding this --wait to the systemd process. Our particular usecase is to have multiple systemd processes, each of which starts roslaunch, but there's one process that's kind of a central process so other roslaunch processes can depend on the roscore that's started from it. This scenario comes into handy when each systemd process is a Docker or any container where each container is modularized and functions by itself, but can also integrated as part of larger systems.

Though we're not sure the usecase and its design described above is the best optimized way yet, this PR by itself makes sense to me.

@msadowski
Copy link
Contributor Author

@130s we've been using this modification for close to a year now. In our case the issue we had was a multi-machine setup where we can't control machine boot up time. By adding a wait flag all the machines wait for the 'master computer' to be up and start it's launchfile.

I think this PR should make sense, especially that "roslaunch_wait" was already implemented but not exposed.

@mikepurvis
Copy link
Member

LGTM.

@mikepurvis mikepurvis merged commit 647bded into clearpathrobotics:kinetic-devel Jul 19, 2019
@130s 130s mentioned this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants