Dirty fix on header_image_file #21
Conversation
| if (isset($page->header()->header_image_file)) { | ||
| $tmp_images = array_replace([], $images); | ||
| foreach ($tmp_images as $image) { | ||
| if (basename($image->url()) != $page->header()->header_image_file) { |
There was a problem hiding this comment.
Why this loop / implementation ?
And why basename for one and not for header_image_file ?
Can you share the interface of header_image_file please ?
There was a problem hiding this comment.
Because you asked to see my "dirty" solution and I am not a PHP developer and I don't know a better approach. Sorry about this.
The loop is to create a list with just the header_image_file as an image object. Basename because, usually, we don't put the full URL when we want to point a header element to an image of the page; we just put the filename on it. I did not find a way to get the filename from the image object, but getting it from the url() works. I think I can't "share the interface" of header_image_file, if you are asking for some specific documentation.
Sorry if I bothered you with this. I just wanted a way to specify (force) the plugin to use a specific image as the og/twitter image and not let it just pick the first one. I think that this would be a good way, to follow what Antimatter defined. Setting a custom header element on plugin settings would be another way to do this, so we could use anything, not just header_image_file. But maybe this would be more complicated.
This is my fix for the header_image_file issue.