Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1: howto personalize description for a specific page ? #5

Merged
merged 1 commit into from Jan 30, 2019
Merged

Conversation

pamtbaau
Copy link
Contributor

The fix for issue #1: howto personalize description for a specific page ? applies the following test to check if a page contains frontmatter for description:

if(!isset($page_header->metadata->description)) {
    $meta['description']['name']      = 'description';
    $meta['description']['content']   = $this->desc;
}

Hower, the value of $page_header->metadata is an array and therefor, !isset($page_header->metadata->description) will always be true. Hence the user-defined frontmatter 'metadata:description' will still be ignored.

The test should be !isset($page_header->metadata['description']

@clemdesign clemdesign merged commit 5c8d991 into clemdesign:master Jan 30, 2019
@clemdesign
Copy link
Owner

Hi pamtbaau,

Thank you a lot for this pull request :-)

I published a release 1.1.3 with your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants