Updates Async extern #160
Merged
Updates Async extern #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's |
|
From Async doc:
|
clemos
requested changes
Apr 14, 2017
js/npm/Async.hx
Outdated
|
|
||
| typedef AsyncCallback<T> = T -> Void; | ||
| typedef AsyncOptionalCallback<T> = ?T -> Void; | ||
| typedef AsyncMapCallback<Err, T> = Err -> T -> Void; | ||
|
|
||
| typedef AsyncLoopCallback<Err> = AsyncCallback<Err> -> Void; | ||
| typedef TaskFunction<T, Err> = ?T -> (Null<Err> -> T); | ||
| typedef Task<T, Err> = EitherType<TaskFunction<T, Err>, Array<EitherType<String, TaskFunction<T, Err>>>>; |
There was a problem hiding this comment.
please prefix, like AsyncTask, AsyncTaskFunction, etc.
There was a problem hiding this comment.
also, maybe it would be nice to standardize Err, T order.
js/npm/Async.hx
Outdated
| @@ -116,3 +150,23 @@ implements npm.Package.Require<"async", "^0.9.0"> | |||
|
|
|||
| public static function noConflict() : Class<Async>; | |||
| } | |||
|
|
|||
| extern class CargoObject<T, Err> { | |||
clemos
requested changes
Apr 14, 2017
js/npm/Async.hx
Outdated
| @@ -112,9 +112,9 @@ implements npm.Package.Require<"async", "^2.3.0"> | |||
|
|
|||
| // queue | |||
| // priorityQueue | |||
| public static function cargo<T, Err>(worker: AsyncMapCallback<T, Err>, payload: Int) : CargoObject<T, Err>; | |||
| public static function cargo<T, Err>(worker: AsyncMapCallback<T, Err>, payload: Int) : AsyncCargoObject<T, Err>; | |||
clemos
approved these changes
Apr 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.