Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid reg exp for splitting source to line #132

Closed
pleclech opened this issue Apr 14, 2017 · 4 comments
Closed

Invalid reg exp for splitting source to line #132

pleclech opened this issue Apr 14, 2017 · 4 comments

Comments

@pleclech
Copy link
Contributor

Hello i think the regex here
https://github.com/clemos/try-haxe/blob/master/src/SourceTools.hx#L6

is invalid as it split also the line with | and the it should split the \r\n before the other one char line.

You can see it in action here:
https://try.haxe.org/#Bdb77

Patrick.

@clemos
Copy link
Owner

clemos commented Apr 14, 2017

Right :)
Could you please make a PR ?

@pleclech
Copy link
Contributor Author

pleclech commented Apr 14, 2017 via email

@clemos
Copy link
Owner

clemos commented Apr 19, 2017

Your fix is online, thx :)

@clemos clemos closed this as completed Apr 19, 2017
@pleclech
Copy link
Contributor Author

You're welcome ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants