Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): Deprecate createSMSMessage #2184

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

Nikpolik
Copy link
Member

@Nikpolik Nikpolik commented Nov 22, 2023

Description

The deprecation commit of #2165 for release in v4

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 馃悰 Bug fix
  • 馃専 New feature
  • 馃敤 Breaking change
  • 馃摉 Refactoring / dependency upgrade / documentation
  • other: Deprecation

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@Nikpolik Nikpolik requested a review from a team as a code owner November 22, 2023 11:05
Copy link

changeset-bot bot commented Nov 22, 2023

馃 Changeset detected

Latest commit: c3e24e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dimkl dimkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃敡 You will also need to use deprecated() method from @clerk/shared/deprecated inside the createSMSMessage()
Is there a replacement for this API or is it completed dropped?

@Nikpolik
Copy link
Member Author

馃敡 You will also need to use deprecated() method from @clerk/shared/deprecated inside the createSMSMessage() Is there a replacement for this API or is it completed dropped?

It's completely dropped.

@Nikpolik Nikpolik force-pushed the nikpolik/deprecate-create-sms branch 3 times, most recently from f5fd5e3 to a8e1592 Compare November 22, 2023 11:38
@Nikpolik
Copy link
Member Author

@dimkl Thanks, I added the deprecated function call. I set the message to This endpoint is no longer available since the Will be removed from clerk... is already logged by the function if I understand correctly.

@Nikpolik Nikpolik force-pushed the nikpolik/deprecate-create-sms branch from a8e1592 to 145aba4 Compare November 22, 2023 12:48
@Nikpolik Nikpolik force-pushed the nikpolik/deprecate-create-sms branch from 145aba4 to c3e24e2 Compare November 22, 2023 12:50
@Nikpolik Nikpolik added this pull request to the merge queue Nov 22, 2023
Merged via the queue into release/v4 with commit e61df05 Nov 22, 2023
6 checks passed
@Nikpolik Nikpolik deleted the nikpolik/deprecate-create-sms branch November 22, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants