feat(backend,clerk-sdk-node): Drop create sms endpoint #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c76832e The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Nikpolik
force-pushed
the
nikpolik/drop-create-sms-endpoint
branch
3 times, most recently
from
a890c6d
to
ca21b16
Compare
nikosdouvlis
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
@Nikpolik This looks good to me :)
If we haven't done that already, we need to add deprecation warnings to the methods in the release/v4 branch as well, letting our users know that these endpoints will be removed.
Nikpolik
force-pushed
the
nikpolik/drop-create-sms-endpoint
branch
from
ca21b16
to
1c4cfa1
Compare
dimkl
approved these changes
Nov 21, 2023
|
@nikosdouvlis I added dba09d9 and will cherry pick this commit to release/v4 after merging! |
Nikpolik
force-pushed
the
nikpolik/drop-create-sms-endpoint
branch
2 times, most recently
from
65d07ee
to
6a6b1cc
Compare
SokratisVidros
approved these changes
Nov 21, 2023
|
|
||
| Deprecate `createSMSMessage` and `SMSMessageApi` from `clerkClient`. | ||
|
|
||
| The equivalent `/sms_messages` Backend API endpoint will also be dropped in the future, since this feature will no longer be available for new instances. |
There was a problem hiding this comment.
Suggested change
| The equivalent `/sms_messages` Backend API endpoint will also be dropped in the future, since this feature will no longer be available for new instances. | |
| The `/sms_messages` Backend API endpoint will also be dropped in the future since this feature will no longer be available for new Clerk instances. |
There was a problem hiding this comment.
@SokratisVidros I had enabled auto merge from yesterday and did not get a chance to update the copyright 😓
There was a problem hiding this comment.
Its updated in #2184 which is for v4 release
This feature is beeing dropped from the Backend API. For a brief period it will still be available for instances that have used it in the past 7 days (13-11-2023 to 20-11-2023). New instances will get a 403 forbidden response if they try to access it.
Nikpolik
force-pushed
the
nikpolik/drop-create-sms-endpoint
branch
from
6a6b1cc
to
c76832e
Compare
24 tasks
desiprisg
pushed a commit
that referenced
this pull request
Nov 23, 2023
* feat(backend): Deprecate createSMSMessage * feat(backend,clerk-sdk-node): Drop create sms endpoint This feature is beeing dropped from the Backend API. For a brief period it will still be available for instances that have used it in the past 7 days (13-11-2023 to 20-11-2023). New instances will get a 403 forbidden response if they try to access it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
createSmsfunctions from@clerk/backendand@clerk/sdk-node.The equivalent
/sms_messagesBackend API endpoint will also be dropped in the future, since this feature will no longer be available for new instances.For a brief period it will still be accessible for instances that have used it in the past 7
days (13-11-2023 to 20-11-2023).
New instances will get a 403 forbidden response if they try to access it.