Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clerk-js): Drop session tokens legacy integration handling #2190

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Nov 22, 2023

Description

After the Clerk server release to allow generating firebase tokens using the integration_firebase template from the sessions/:sessionID/tokens/:template endpoint, we can drop the this legacy code.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@dimkl dimkl self-assigned this Nov 22, 2023
Copy link

changeset-bot bot commented Nov 22, 2023

🦋 Changeset detected

Latest commit: 7ad8d49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Copy link
Member

@nikosdouvlis nikosdouvlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the oldest pieces of legacy code in the codebase :)

@dimkl dimkl added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit d941b90 Nov 23, 2023
7 checks passed
@dimkl dimkl deleted the sdk-917-drop-me-tokens branch November 23, 2023 12:02
@dimkl
Copy link
Contributor Author

dimkl commented Nov 23, 2023

We merged this prior to the Clerk endpoint change since they will both be released as part of the v5 and it's safe.

desiprisg pushed a commit that referenced this pull request Nov 23, 2023
Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants