chore(*): Improve @clerk/backend DX [Part 1 - Refactoring] #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3eb7f72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
24 tasks
dimkl
force-pushed
the
sdk-974-improve-dx-backend-p1-refactors
branch
from
d941960
to
88fab3a
Compare
nikosdouvlis
approved these changes
Dec 15, 2023
packages/backend/src/runtime.ts
Outdated
|
|
||
| // @ts-ignore - These are package subpaths | ||
| import crypto from '#crypto'; | ||
| let webcrypto; |
There was a problem hiding this comment.
Why did you remove the subpath import here? Are you trying to make Jest work without configuring a moduleMapper? If so, Jest claims that that subpath imports work since this release: https://github.com/jestjs/jest/releases/tag/v29.4.0 :) #til
I haven't tested the following, but this is what I had in mind for #crypto:
node/crypto.mjs:
export { webcrypto } from 'node:crypto';
node/crypto.js:
module.exports.webcrypto = require('node:crypto').webcrypto;
package.json:
"imports": {
"#crypto": {
"edge-light": "./dist/runtime/browser/crypto.mjs",
"worker": "./dist/runtime/browser/crypto.mjs",
"browser": "./dist/runtime/browser/crypto.mjs",
"node": {
"require": "./dist/runtime/node/crypto.js",
"import": "./dist/runtime/node/crypto.mjs"
},
"default": "./dist/runtime/browser/crypto.mjs"
}
},
runtime.ts:
import { webcrypto } from '#crypto';
...
There was a problem hiding this comment.
Change reverted and suggestion applied.
dimkl
force-pushed
the
sdk-974-improve-dx-backend-p1-refactors
branch
from
88fab3a
to
98dae0d
Compare
dimkl
force-pushed
the
sdk-974-improve-dx-backend-p1-refactors
branch
from
98dae0d
to
3eb7f72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply some internal refactoring and restructuring to
@clerk/backend.Review it per commit for more information.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore