Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): Improve @clerk/backend DX [Part 3 - Internal subpath exports] #2363

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Dec 14, 2023

Description

Introduce @clerk/backend/internal and move some exports from top-level to the subpath. This change causes the removal of those exports from all the packages re-exporting from @clerk/backend (eg @clerk/nextjs).

Check changeset for examples and more information.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Dec 14, 2023

🦋 Changeset detected

Latest commit: 66cf3e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
gatsby-plugin-clerk Major
@clerk/clerk-sdk-node Major
@clerk/backend Major
@clerk/fastify Major
@clerk/nextjs Major
@clerk/remix Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikosdouvlis
Copy link
Member

@dimkl Shall we add the

/**
* @internal
* 

jsdoc directive to these as well?

@dimkl dimkl force-pushed the sdk-974-improve-dx-backend-p2-errors branch from 2776f31 to 802b762 Compare December 15, 2023 10:50
@dimkl dimkl force-pushed the sdk-974-improve-dx-backend-p3-internal branch 2 times, most recently from 1919cec to 7d9bf93 Compare December 15, 2023 11:40
@dimkl
Copy link
Contributor Author

dimkl commented Dec 15, 2023

/**

i have added the @internal JSDoc

@dimkl dimkl force-pushed the sdk-974-improve-dx-backend-p2-errors branch from 06c64d6 to 637d245 Compare December 15, 2023 11:45
@dimkl dimkl force-pushed the sdk-974-improve-dx-backend-p3-internal branch from 7d9bf93 to 3821d39 Compare December 15, 2023 11:47
Base automatically changed from sdk-974-improve-dx-backend-p2-errors to main December 15, 2023 11:57
@dimkl dimkl force-pushed the sdk-974-improve-dx-backend-p3-internal branch from 3821d39 to 66cf3e8 Compare December 15, 2023 11:58
@dimkl dimkl enabled auto-merge December 15, 2023 11:59
@nikosdouvlis nikosdouvlis merged commit 0ec3a14 into main Dec 15, 2023
6 of 8 checks passed
@nikosdouvlis nikosdouvlis deleted the sdk-974-improve-dx-backend-p3-internal branch December 15, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants