fix(clerk-react): Properly fire onLoad event when clerk-js is already loaded #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… loaded In case of mounting-unmounting-mounting the `IsomorphicClerk.addOnLoaded` would not fire correctly, hence `derivedState` would return the initialState instead of the client side state. In addition to the above fix, we are now cleaning up the IsomorphicClerk instance when the provider is unmounted.
🦋 Changeset detectedLatest commit: 882337d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
approved these changes
Feb 8, 2024
| return () => { | ||
| IsomorphicClerk.clearInstance(); | ||
| }; | ||
| }, []); |
There was a problem hiding this comment.
❓ shouldn't we merge this useEffect with the one above that initializes the isomorphicClerk.addOnLoaded ?
There was a problem hiding this comment.
The actual initialization happends in the useMemo
const isomorphicClerk = React.useMemo(() => IsomorphicClerk.getOrCreateInstance(options), []);. So i'm not sure, the position shouldn't affect the result tho.
panteliselef
added a commit
that referenced
this pull request
Feb 9, 2024
… loaded (#2757) In case of mounting-unmounting-mounting the `IsomorphicClerk.addOnLoaded` would not fire correctly, hence `derivedState` would return the initialState instead of the client side state. In addition to the above fix, we are now cleaning up the IsomorphicClerk instance when the provider is unmounted. (cherry picked from commit 6ac9e71)
This was referenced Feb 9, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
… loaded (#2757) (#2767) In case of mounting-unmounting-mounting the `IsomorphicClerk.addOnLoaded` would not fire correctly, hence `derivedState` would return the initialState instead of the client side state. In addition to the above fix, we are now cleaning up the IsomorphicClerk instance when the provider is unmounted. (cherry picked from commit 6ac9e71) Co-authored-by: panteliselef <panteliselef@outlook.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of mounting-unmounting-mounting the
IsomorphicClerk.addOnLoadedwould not fire correctly, hencederivedStatewould return the initialState instead of the client side state.In addition to the above fix, we are now cleaning up the IsomorphicClerk instance when the provider is unmounted.
Description
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore