Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js): Handle PSU and MFA flows for <GoogleOneTap/> #3250

Merged

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Apr 24, 2024

Public API updates

By default we are returning back to the location where the flow started.
To accomplish that internally we will use the redirect_url query parameter to build the url.

<__experimental_GoogleOneTap />

In the above example if there is a SIGN_UP_FORCE_REDIRECT_URL or SIGN_IN_FORCE_REDIRECT_URL set then the developer would need to pass new values as props like this

<__experimental_GoogleOneTap
  signInForceRedirectUrl=""
  signUpForceRedirectUrl=""
/>

Let the developer configure the experience they want to offer. (All these values are true by default)

<__experimental_GoogleOneTap
  cancelOnTapOutside={false}
  itpSupport={false}
  fedCmSupport={false}
/>

Moved authenticateWithGoogleOneTap to Clerk singleton

Clerk.__experimental_authenticateWithGoogleOneTap

Created the handleGoogleOneTapCallback in Clerk singleton

Clerk.__experimental_handleGoogleOneTapCallback

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: 38ae0bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@clerk/clerk-js Minor
@clerk/types Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/testing Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef panteliselef force-pushed the elef/sdk-1680-respect-mfa-and-psu-flows-in-googleonetap branch from 2972819 to bdc0e45 Compare April 24, 2024 12:12
@panteliselef panteliselef marked this pull request as ready for review April 24, 2024 12:12
@panteliselef panteliselef self-assigned this Apr 24, 2024
Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 💯

@panteliselef panteliselef enabled auto-merge (squash) May 14, 2024 08:40
@panteliselef panteliselef merged commit 9419771 into main May 14, 2024
10 checks passed
@panteliselef panteliselef deleted the elef/sdk-1680-respect-mfa-and-psu-flows-in-googleonetap branch May 14, 2024 09:13
@clerk-cookie clerk-cookie mentioned this pull request May 14, 2024
@panteliselef panteliselef mentioned this pull request May 21, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants