-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clerk-js): Handle PSU and MFA flows for <GoogleOneTap/>
#3250
Merged
panteliselef
merged 18 commits into
main
from
elef/sdk-1680-respect-mfa-and-psu-flows-in-googleonetap
May 14, 2024
Merged
feat(clerk-js): Handle PSU and MFA flows for <GoogleOneTap/>
#3250
panteliselef
merged 18 commits into
main
from
elef/sdk-1680-respect-mfa-and-psu-flows-in-googleonetap
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 38ae0bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Use buildURLWithAuth - Build urls with correct redirect urls when leaving app for AP
panteliselef
force-pushed
the
elef/sdk-1680-respect-mfa-and-psu-flows-in-googleonetap
branch
from
April 24, 2024 12:12
2972819
to
bdc0e45
Compare
anagstef
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 💯
panteliselef
deleted the
elef/sdk-1680-respect-mfa-and-psu-flows-in-googleonetap
branch
May 14, 2024 09:13
Merged
panteliselef
added a commit
that referenced
this pull request
May 21, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API updates
By default we are returning back to the location where the flow started.
To accomplish that internally we will use the
redirect_url
query parameter to build the url.In the above example if there is a
SIGN_UP_FORCE_REDIRECT_URL
orSIGN_IN_FORCE_REDIRECT_URL
set then the developer would need to pass new values as props like thisLet the developer configure the experience they want to offer. (All these values are true by default)
Moved authenticateWithGoogleOneTap to Clerk singleton
Created the handleGoogleOneTapCallback in Clerk singleton
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change