-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for <GoogleOneTap/>
#3409
Conversation
🦋 Changeset detectedLatest commit: 3895193 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1231228
to
8dfc2f4
Compare
<GoogleOneTap/>
}) | ||
.catch(err => { | ||
if (isClerkAPIResponseError(err) && err.errors[0].code === 'external_account_not_found') { | ||
return this.client?.signUp.create({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panteliselef I think I've mentioned this before, but I'm double-checking that this signUp.create
will trigger a Captcha functionality, and if the user has selected the "Smart" option it will try to find the clerk-captcha
in the DOM. Thankfully, it won't break, because we fallback to "Invisible", but the fallback mechanism may change in the future, we should not depend on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Description
This PR backports into Core 1
<GoogleOneTap/>
#3250Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change