-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clerk-js,clerk-react): Replace mount with open for GoogleOneTap #3379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3bdeb5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
force-pushed
the
elef/open-google-one-tap
branch
from
May 14, 2024 16:54
e66e26e
to
34c7829
Compare
panteliselef
force-pushed
the
elef/open-google-one-tap
branch
from
May 14, 2024 16:56
34c7829
to
235e559
Compare
octoper
reviewed
May 15, 2024
octoper
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
panteliselef
commented
May 15, 2024
nikosdouvlis
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The interaction with Google One Tap resembles a modal like experience and that is why we decided to drop the "mount" method and use "open" for the low level clerk-js API.
We still want to support the
GoogleOneTap
react component that a user can simply mount in their application.To achieve both things mentioned above, a few changes were necessary to be made in the internal
Portal
components ofclerk-js
andclerk-react
This PR introduces:
Clerk.__experimental_openGoogleOneTap(props)
Clerk.__experimental_closeGoogleOneTap()
and drops
Clerk.__experimental_mountGoogleOneTap(element, props)
Clerk.__experimental_unmountGoogleOneTap(element)
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change