Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(repo): Add next v13 variant to e2e tests #3431

Merged
merged 11 commits into from
May 29, 2024
Merged

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented May 23, 2024

Description

Previously we were only running e2e tests for the next version defined in the package.json file of its template.
With this PR we are adding a configuration to always run the test with an app with latest next@13 and another app with latest next@14

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 馃悰 Bug fix
  • 馃専 New feature
  • 馃敤 Breaking change
  • 馃摉 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented May 23, 2024

鈿狅笍 No Changeset found

Latest commit: 95e7e65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@panteliselef panteliselef marked this pull request as ready for review May 24, 2024 08:47
Copy link
Member

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Someone with Admin rights would need to remove the old workflow as required and add the two new ones as required afterwards

@LekoArts LekoArts mentioned this pull request May 24, 2024
9 tasks
@panteliselef panteliselef merged commit f7057e8 into main May 29, 2024
11 of 12 checks passed
@panteliselef panteliselef deleted the elef/next-13-e2e branch May 29, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants